zeroshade commented on code in PR #762:
URL: https://github.com/apache/iceberg-go/pull/762#discussion_r2885039075
##########
table/arrow_scanner.go:
##########
@@ -205,6 +206,8 @@ func enrichRecordsWithPosDeleteFields(ctx context.Context,
filePath iceberg.Data
panic("position delete schema should have required field 'pos'")
}
+ newColsSchema := arrow.NewSchema([]arrow.Field{filePathField[0],
posField[0]}, nil)
Review Comment:
since we control the PositionalDeleteArrowSchema as a global, do we really
need these checks?
Can't we just use `PositionalDeleteArrowSchema` as-is without needing to
create an entirely new schema object here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
