pvary commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2840164523
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -78,6 +78,7 @@ enum TransactionType {
private TableMetadata base;
private TableMetadata current;
private boolean hasLastOpCommitted;
+ private boolean isAborted = false;
Review Comment:
What is the order of the calls during the Hive commit?
1. Stage every change (is this calling the original commit, but the ops are
changes so they not really commit, just prepare?)
2. Lock every table
3. Check if no change happened to the tables
4. Update every table metadata (calling a real commit on all the ops)
5. Release locks
?
I'm not big fan of the change in `TableOperations`.
Maybe remove the state checks in `BaseTransaction`, or expose them on the
`BaseTransaction` like `BaseTransaction.checkState(State from, State to)`.
I prefer to remove the checks at this point. Any better ideas
@RussellSpitzer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
