deniskuzZ commented on PR #15389: URL: https://github.com/apache/iceberg/pull/15389#issuecomment-3941747417
> Extra tests: > > * Cannot add changed to a txn after abort or commit > * dual commit forbidden > * abort after commit forbidden > * dual abort ok, but second attempt a no-op. > > Actually,given the subclassing, forbidding dual abort is the way to guarantee subclasses don't do things on a second abort call added tests. @steveloughran, FYI subclassing is restricted by package-private constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
