geruh commented on code in PR #3007:
URL: https://github.com/apache/iceberg-python/pull/3007#discussion_r2780348489


##########
.github/workflows/python-ci.yml:
##########
@@ -178,6 +178,32 @@ jobs:
         path: .coverage*
         include-hidden-files: true
 
+  benchmark-test:

Review Comment:
   Could we run the benchmarks against main as a baseline in the same job? It 
would be cool to create a report of all the benchmarks that can be uploaded 
onto the PR. Maybe we should think of this a bit more.



##########
.github/workflows/python-ci.yml:
##########
@@ -178,6 +178,32 @@ jobs:
         path: .coverage*
         include-hidden-files: true
 

Review Comment:
   Could we run the benchmarks against main as a baseline in the same job? It 
would be cool to create a report of all the benchmarks that can be uploaded 
onto the PR. Maybe we should think of this a bit more. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to