geruh commented on code in PR #3007:
URL: https://github.com/apache/iceberg-python/pull/3007#discussion_r2780331652
##########
Makefile:
##########
@@ -133,6 +133,9 @@ test-gcs: ## Run tests marked with @pytest.mark.gcs
sh ./dev/run-gcs-server.sh
$(TEST_RUNNER) pytest tests/ -m gcs $(PYTEST_ARGS)
Review Comment:
nit: `test_partitioned_write` downloads a ~38MB taxi dataset from CloudFront
on every CI run. It's the only CI job that depends on an external CDN — if it
goes down this job fails. Might be worth a comment here noting the network
dependency, or consider caching it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
