kevinjqliu commented on code in PR #2979:
URL: https://github.com/apache/iceberg-python/pull/2979#discussion_r2742598053
##########
Makefile:
##########
@@ -66,17 +66,15 @@ install-uv: ## Ensure uv is installed
echo "uv is already installed."; \
fi
-setup-venv: ## Create virtual environment
- uv venv $(PYTHON_ARG)
-
-install-dependencies: setup-venv ## Install all dependencies including extras
- uv sync $(PYTHON_ARG) --all-extras --reinstall
-
-install-hooks: ## Install pre-commit hooks
+install: install-uv ## Install uv, dependencies, and pre-commit hooks
+ uv sync $(PYTHON_ARG) --all-extras
+ @# Reinstall pyiceberg if Cython extensions (.so) are missing after
`make clean` (see #2869)
+ @if ! find pyiceberg -name "*.so" 2>/dev/null | grep -q .; then \
Review Comment:
since `uv sync` is super fast, its fine to call it (potentially) twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
