kevinjqliu commented on code in PR #2979:
URL: https://github.com/apache/iceberg-python/pull/2979#discussion_r2742351744
##########
Makefile:
##########
@@ -66,11 +66,15 @@ install-uv: ## Ensure uv is installed
echo "uv is already installed."; \
fi
-setup-venv: ## Create virtual environment
- uv venv $(PYTHON_ARG)
+setup-venv: ## Create virtual environment (if not exists)
+ @if [ ! -d ".venv" ]; then \
+ uv venv $(PYTHON_ARG); \
+ else \
+ echo "Virtual environment already exists at .venv"; \
+ fi
install-dependencies: setup-venv ## Install all dependencies including extras
- uv sync $(PYTHON_ARG) --all-extras --reinstall
+ uv sync $(PYTHON_ARG) --all-extras
Review Comment:
yes i totally forgot, this was
https://github.com/apache/iceberg-python/pull/2869
i added the conditional logic and a comment for so we dont forget again 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
