CTTY commented on code in PR #2080:
URL: https://github.com/apache/iceberg-rust/pull/2080#discussion_r2739387690
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -366,63 +331,42 @@ pub trait FileWrite: Send + Unpin + 'static {
async fn close(&mut self) -> crate::Result<()>;
}
-#[async_trait::async_trait]
-impl FileWrite for opendal::Writer {
- async fn write(&mut self, bs: Bytes) -> crate::Result<()> {
- Ok(opendal::Writer::write(self, bs).await?)
- }
-
- async fn close(&mut self) -> crate::Result<()> {
- let _ = opendal::Writer::close(self).await?;
- Ok(())
- }
-}
Review Comment:
Same here, moved this to `storage.rs`, and will move this to
`iceberg-storage/opendal/` in the future, because this is opendal specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
