CTTY commented on code in PR #2080:
URL: https://github.com/apache/iceberg-rust/pull/2080#discussion_r2739385743
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -291,59 +268,47 @@ pub trait FileRead: Send + Sync + Unpin + 'static {
async fn read(&self, range: Range<u64>) -> crate::Result<Bytes>;
}
-#[async_trait::async_trait]
-impl FileRead for opendal::Reader {
- async fn read(&self, range: Range<u64>) -> crate::Result<Bytes> {
- Ok(opendal::Reader::read(self, range).await?.to_bytes())
- }
-}
-
Review Comment:
Moved this to `storage.rs`, and will move this to `iceberg-storage/opendal/`
in the future, because this is opendal specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
