dramaticlly commented on PR #15003:
URL: https://github.com/apache/iceberg/pull/15003#issuecomment-3801408903

   > I'm generally +1 on this idea but don't have time to do a full review 
right now, I do think we should consider using "existing" instead of "kept"? Or 
maybe skip it all together since I think we aren't tracking manifests which are 
not scanned in the first place right?
   
   Thanks @RussellSpitzer , discussed offline as we reuse the SnapshotSummary 
already defined in 
https://iceberg.apache.org/spec/#optional-snapshot-summary-fields. Previously 
we only populate such for 
[rewrite-manifest](https://github.com/apache/iceberg/blob/f5635a65676df12b00f2c8365357d6026202b397/api/src/main/java/org/apache/iceberg/RewriteManifests.java#L38)
 operation, this change I want to introduce them for all commits result in a 
new snapshot, like append, row-delta and delete etc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to