RussellSpitzer commented on code in PR #15003:
URL: https://github.com/apache/iceberg/pull/15003#discussion_r2728961189


##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -313,6 +315,18 @@ private Set<F> deletedFiles(ManifestFile[] manifests) {
     return deletedFiles;
   }
 
+  /**
+   * Returns the count of manifests that were replaced (rewritten) during 
filtering.
+   *
+   * <p>A manifest is considered replaced when a new manifest was created to 
replace the original
+   * one (i.e., the original manifest != filtered manifest).

Review Comment:
   Just a note because of the normal append path in merging snapshot producer 
this can also be original manifest != appended manifest



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to