wgtmac commented on code in PR #438:
URL: https://github.com/apache/iceberg-cpp/pull/438#discussion_r2647140736
##########
src/iceberg/catalog/rest/http_client.cc:
##########
@@ -240,12 +240,13 @@ Result<HttpResponse> HttpClient::Head(
}
Result<HttpResponse> HttpClient::Delete(
- const std::string& path, const std::unordered_map<std::string,
std::string>& headers,
+ const std::string& path, const std::unordered_map<std::string,
std::string>& params,
+ const std::unordered_map<std::string, std::string>& headers,
const ErrorHandler& error_handler) {
cpr::Response response;
{
std::lock_guard guard(session_mutex_);
- PrepareSession(path, headers);
+ PrepareSession(path, headers, params);
Review Comment:
Let's reorder params and headers for `PrepareSession` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
