liurenjie1024 commented on code in PR #1953:
URL: https://github.com/apache/iceberg-rust/pull/1953#discussion_r2644559725
##########
crates/sqllogictest/src/engine/mod.rs:
##########
@@ -17,29 +17,45 @@
mod datafusion;
+use std::collections::HashMap;
use std::path::Path;
use anyhow::anyhow;
+use serde::Deserialize;
use sqllogictest::{AsyncDB, MakeConnection, Runner, parse_file};
-use toml::Table as TomlTable;
use crate::engine::datafusion::DataFusionEngine;
use crate::error::{Error, Result};
-const TYPE_DATAFUSION: &str = "datafusion";
+/// Configuration for the catalog used by an engine
+#[derive(Debug, Clone, Deserialize)]
+pub struct CatalogConfig {
Review Comment:
```suggestion
pub struct DatafusionCatalogConfig {
```
We will support more engines in future, for example spark engine, and this
catalog config is datafusion specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
