AndreaBozzo commented on code in PR #1953:
URL: https://github.com/apache/iceberg-rust/pull/1953#discussion_r2642439466
##########
crates/sqllogictest/src/engine/datafusion.rs:
##########
@@ -59,20 +58,22 @@ impl EngineRunner for DataFusionEngine {
}
impl DataFusionEngine {
- pub async fn new(config: TomlTable) -> Result<Self> {
+ pub async fn new(_name: &str, config: &EngineConfig) -> Result<Self> {
Review Comment:
I thought that if there are multiple instances, this could help debug/log
which one fails. As this is actually currently unclear, i'll remove this, we
can always re-add it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
