singhpk234 commented on code in PR #14882:
URL: https://github.com/apache/iceberg/pull/14882#discussion_r2640623956
##########
core/src/main/java/org/apache/iceberg/SingleValueParser.java:
##########
@@ -414,4 +387,68 @@ public static void toJson(Type type, Object defaultValue,
JsonGenerator generato
throw new UnsupportedOperationException(String.format("Type: %s is not
supported", type));
}
}
+
+ private static Object parseDateValue(Type type, JsonNode value) {
+ if (value.isTextual()) {
+ return DateTimeUtil.isoDateToDays(value.textValue());
+ } else if (value.isIntegralNumber() && value.canConvertToInt()) {
Review Comment:
when we serialize the expression the date types are converted to the
integer. hence during deserialization we need we would need this to convert int
to date, hence i added it here. please let me know if i am missing something
here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
