singhpk234 commented on code in PR #14882:
URL: https://github.com/apache/iceberg/pull/14882#discussion_r2640614693
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -773,18 +774,20 @@ static void clearPlanningState() {
*
* @param scan the scan to configure
* @param request the plan table scan request containing filters and
projections
+ * @param schema the table schema to use for type-aware filter
deserialization
* @param <T> the specific scan type (TableScan, IncrementalAppendScan, etc.)
* @return the configured scan with filters and projections applied
*/
private static <T extends Scan<T, FileScanTask, ?>> T configureScan(
- T scan, PlanTableScanRequest request) {
+ T scan, PlanTableScanRequest request, Schema schema) {
T configuredScan = scan;
if (request.select() != null) {
configuredScan = configuredScan.select(request.select());
}
- if (request.filter() != null) {
- configuredScan = configuredScan.filter(request.filter());
+ Expression filter = request.filter(schema);
Review Comment:
i removed the .filter() check because we are marking that as deprecated and
if we do this check this way i.e first try deserialize (if its null we bail out
early) and based on the nullbability that we feed it to our scan down. Please
let me know wdyt considering above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
