gaborkaszab commented on code in PR #14870:
URL: https://github.com/apache/iceberg/pull/14870#discussion_r2631109426
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -474,6 +476,23 @@ public <T extends RESTResponse> T handleRequest(
break;
}
+ case REGISTER_VIEW:
+ {
+ if (null != asViewCatalog) {
+ LoadViewResponse response =
+ CatalogHandlers.registerView(
+ asViewCatalog,
+ namespaceFromPathVars(vars),
+ castRequest(RegisterViewRequest.class, body));
+
+ responseHeaders.accept(
Review Comment:
Not convinced yet if ETags make sense for views. First I'd like to finish
the implementation of the ETag usage for tables (freshness-aware loading) and
then we can take a look at how much we'd gain with the same for views. My
assumption is that view metadata is smaller than table metadata, so not sure if
it's worth the hassle, but could be investigated later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
