ajantha-bhat commented on code in PR #14870:
URL: https://github.com/apache/iceberg/pull/14870#discussion_r2631075027
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -474,6 +476,23 @@ public <T extends RESTResponse> T handleRequest(
break;
}
+ case REGISTER_VIEW:
+ {
+ if (null != asViewCatalog) {
+ LoadViewResponse response =
+ CatalogHandlers.registerView(
+ asViewCatalog,
+ namespaceFromPathVars(vars),
+ castRequest(RegisterViewRequest.class, body));
+
+ responseHeaders.accept(
Review Comment:
Good catch. I have updated the PR now.
I was following register table and didn't observe that we don't have ETag
for views. Should we have a ticket to implement ETags for views?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
