Kontinuation commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2629460189
##########
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java:
##########
@@ -284,6 +287,14 @@ public String toString() {
return term() + " startsWith \"" + literal() + "\"";
case NOT_STARTS_WITH:
return term() + " notStartsWith \"" + literal() + "\"";
+ case ST_INTERSECTS:
+ case ST_DISJOINT:
+ {
+ ByteBuffer serializedBoundingBox = (ByteBuffer) literal().value();
Review Comment:
Implemented toString for `BoundingBoxLiteral`.
##########
api/src/main/java/org/apache/iceberg/expressions/Evaluator.java:
##########
@@ -156,5 +157,15 @@ public <T> Boolean startsWith(Bound<T> valueExpr,
Literal<T> lit) {
public <T> Boolean notStartsWith(Bound<T> valueExpr, Literal<T> lit) {
return !startsWith(valueExpr, lit);
}
+
+ @Override
+ public <T> Boolean stIntersects(Bound<T> valueExpr, Literal<ByteBuffer>
literal) {
+ throw new UnsupportedOperationException("Evaluation of stIntersects is
not implemented.");
Review Comment:
Removed them from this PR.
##########
api/src/main/java/org/apache/iceberg/expressions/Expression.java:
##########
@@ -44,6 +44,8 @@ enum Operation {
OR,
STARTS_WITH,
NOT_STARTS_WITH,
+ ST_INTERSECTS,
Review Comment:
The operators after it are aggregation operators. I'd like to group ordinary
operators together before the aggregation operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
