huaxingao commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2616507394
##########
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java:
##########
@@ -284,6 +288,15 @@ public String toString() {
return term() + " startsWith \"" + literal() + "\"";
case NOT_STARTS_WITH:
return term() + " notStartsWith \"" + literal() + "\"";
+ case ST_INTERSECTS:
+ case ST_DISJOINT:
+ {
+ ByteBuffer serializedBoundingBox = (ByteBuffer) literal().value();
+ serializedBoundingBox.order(ByteOrder.LITTLE_ENDIAN);
Review Comment:
This changes the ByteBuffer object stored inside the literal. Even though
it’s just the byte order, toString() should be side-effect free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
