erkanonl commented on code in PR #14872:
URL: https://github.com/apache/iceberg/pull/14872#discussion_r2627790855
##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -240,6 +245,14 @@ public int succeededCommits() {
return succeededCommits;
}
+ public int failedCommits() {
+ return failedCommits;
+ }
+
Review Comment:
I looked at the tests of TestCommitService. We test the main behaviour but
tests don't test minor/simple details like succeededCommits so I think it's
fine to leave it as it is because what we do is just incrementing another
variable and adding exceptions into a new list.
##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -57,10 +57,12 @@ abstract class BaseCommitService<T> implements Closeable {
private final ConcurrentLinkedQueue<T> completedRewrites;
private final ConcurrentLinkedQueue<String> inProgressCommits;
private final ConcurrentLinkedQueue<T> committedRewrites;
+ private final List<Exception> exceptionsOfFailedCommits;
Review Comment:
Committer service looks to be executed with a single thread through
`Executors.newSingleThreadExecutor`
However; to be consistent and making it resistant to future changes, I'm
making it `Collections.synchronizedList(Lists.newArrayList());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
