stubz151 commented on code in PR #14872:
URL: https://github.com/apache/iceberg/pull/14872#discussion_r2627174872
##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -240,6 +245,14 @@ public int succeededCommits() {
return succeededCommits;
}
+ public int failedCommits() {
+ return failedCommits;
+ }
+
+ public List<Exception> exceptionsOfFailedCommits() {
+ return Lists.newArrayList(exceptionsOfFailedCommits);
Review Comment:
why not just return exceptionsOfFailedCommits?
##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -57,10 +57,12 @@ abstract class BaseCommitService<T> implements Closeable {
private final ConcurrentLinkedQueue<T> completedRewrites;
private final ConcurrentLinkedQueue<String> inProgressCommits;
private final ConcurrentLinkedQueue<T> committedRewrites;
+ private final List<Exception> exceptionsOfFailedCommits;
Review Comment:
This might have to be a synchronizedList right?
##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -240,6 +245,14 @@ public int succeededCommits() {
return succeededCommits;
}
+ public int failedCommits() {
+ return failedCommits;
+ }
+
Review Comment:
think we should add some tests for this behaviour, but am happy to get
buy-in first for this change before we do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
