pvary commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2606087020
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultSerializer.java:
##########
@@ -41,6 +41,7 @@ public byte[] serialize(DynamicWriteResult writeResult)
throws IOException {
ByteArrayOutputStream out = new ByteArrayOutputStream();
DataOutputViewStreamWrapper view = new DataOutputViewStreamWrapper(out);
writeResult.key().serializeTo(view);
+ view.writeInt(writeResult.specId());
Review Comment:
Do we need to have a new version? WriteResults serialized with the old
version will not be readable with the new serializer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
