pvary commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2606020361
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -210,36 +218,40 @@ private void commitPendingRequests(
NavigableMap<Long, List<WriteResult>> pendingResults = Maps.newTreeMap();
for (Map.Entry<Long, List<CommitRequest<DynamicCommittable>>> e :
commitRequestMap.entrySet()) {
for (CommitRequest<DynamicCommittable> committable : e.getValue()) {
- if (Arrays.equals(EMPTY_MANIFEST_DATA,
committable.getCommittable().manifest())) {
+ if (Arrays.deepEquals(EMPTY_MANIFEST_DATA,
committable.getCommittable().manifests())) {
Review Comment:
This logic is not good in this way. We need to combine it to the `manifests`
loop below.
The end goal what we want to archive:
- Every manifest should be in the `pendingResults` which is not
`EMPTY_MANIFEST_DATA`
- If the `pendingResults` is empty, then put a single `EMPTY_MANIFEST_DATA`
into it
We shouldn't put `EMPTY_MANIFEST_DATA` to the `pendingResults`. And but put
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
