kevinjqliu commented on code in PR #2796: URL: https://github.com/apache/iceberg-python/pull/2796#discussion_r2599493895
########## mkdocs/docs/configuration.md: ########## @@ -573,6 +573,19 @@ catalog: <!-- prettier-ignore-end --> +##### Microsoft Fabric OneLake Catalog REST + +```yaml +catalog: + onelake_catalog: + type: rest + uri: https://onelake.table.fabric.microsoft.com/iceberg + warehouse: <fabric_workspace_id>/<fabric_data_item_id> # Example : DB0CE1EE-B014-47D3-8F0C-9D64C39C0FC2/F470A1D2-6D6D-4C9D-8796-46286C80B7C0 + adls.account-name: onelake, + adls.account-host: onelake.blob.fabric.microsoft.com, + adls.credential: <credential>, # You can use DefautlAzureCredential from `azure.identity` package or refer to other authentication flows from [here](https://learn.microsoft.com/en-us/entra/identity-platform/authentication-flows-app-scenarios) Review Comment: nit: the hyperlink wont be rendered here since its inside the yaml block maybe move this outside as a "Note". For example, see the one in the GCP instructions above ########## mkdocs/docs/configuration.md: ########## @@ -573,6 +573,19 @@ catalog: <!-- prettier-ignore-end --> +##### Microsoft Fabric OneLake Catalog REST + +```yaml +catalog: + onelake_catalog: Review Comment: "token" is missing here, when compared to https://learn.microsoft.com/en-us/fabric/onelake/table-apis/iceberg-table-apis-get-started#pyiceberg ########## mkdocs/docs/configuration.md: ########## @@ -573,6 +573,19 @@ catalog: <!-- prettier-ignore-end --> +##### Microsoft Fabric OneLake Catalog REST + Review Comment: could you also add a link to https://aka.ms/onelakeircdocs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
