pvary commented on code in PR #14435:
URL: https://github.com/apache/iceberg/pull/14435#discussion_r2592028802
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -119,7 +120,7 @@ protected RewriteDataFilesSparkAction self() {
@Override
public RewriteDataFilesSparkAction binPack() {
ensureRunnerNotSet();
- this.runner = new SparkBinPackFileRewriteRunner(spark(), table);
+ this.runner = createFileRewriteRunner();
Review Comment:
nit: could we inline the method? It is not used anywhere and this is a
fairly short method here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
