kevinjqliu commented on code in PR #14724:
URL: https://github.com/apache/iceberg/pull/14724#discussion_r2582517618
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogServlet.java:
##########
@@ -133,6 +135,20 @@ protected void execute(ServletRequestContext context,
HttpServletResponse respon
}
}
+ private boolean canReturn204(Route route) {
Review Comment:
`shouldReturn204` makes sense to me.
and yes, good point. Route already has both
https://github.com/apache/iceberg/blob/da76b873fad9b87c76eed1e91185e7b9fcb9a7f8/core/src/test/java/org/apache/iceberg/rest/Route.java#L62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
