amogh-jahagirdar commented on code in PR #14724:
URL: https://github.com/apache/iceberg/pull/14724#discussion_r2582424154


##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogServlet.java:
##########
@@ -133,6 +135,20 @@ protected void execute(ServletRequestContext context, 
HttpServletResponse respon
     }
   }
 
+  private boolean canReturn204(Route route) {

Review Comment:
   The route enum already encapsulates the method as well so we should be OK 
here. My nit here is I think this method should be called `shouldReturn204`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to