singhpk234 commented on code in PR #14730:
URL: https://github.com/apache/iceberg/pull/14730#discussion_r2579159470
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -824,6 +828,8 @@ paths:
- Catalog API
summary: Fetches result tasks for a plan task
operationId: fetchScanTasks
+ parameters:
+ - $ref: '#/components/parameters/idempotency-key'
Review Comment:
> however, in the current implementation both sync and async planning call
planFilesFor
This is for the RESTCatalogAdapter which is only used for tests, IMHO real
server side implementation for example Apache Polaris would like to use the
idempotency key since it might happen we would not materialized it later like
all mutating endpoint i would consider this to be mutating too hence we went
with verb POST instead of GET to give the flexibility, please let me know your
thoughts considering this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
