singhpk234 commented on code in PR #14730:
URL: https://github.com/apache/iceberg/pull/14730#discussion_r2578424298
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -824,6 +828,8 @@ paths:
- Catalog API
summary: Fetches result tasks for a plan task
operationId: fetchScanTasks
+ parameters:
+ - $ref: '#/components/parameters/idempotency-key'
Review Comment:
Thinking more of this in async planning its not necessary that the server
has materialized the fileScanTask and the corresponding plantask which it wants
to return as part in the response, server has just said hey i have completed
the planning, it may be that planTask corresponds to a manifest and the server
hasn't opened the manifest and based on the consumption rate migh decide to
give more than one planTasks ?
knowing that its the same client thats hitting this endpoint would be
helpful IMHO, wdyt ?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -766,6 +768,8 @@ paths:
- Catalog API
summary: Cancels scan planning for a plan-id
operationId: cancelPlanning
+ parameters:
+ - $ref: '#/components/parameters/idempotency-key'
Review Comment:
Agree with you removing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
