zhjwpku commented on code in PR #370:
URL: https://github.com/apache/iceberg-cpp/pull/370#discussion_r2573602002
##########
src/iceberg/table.h:
##########
@@ -115,6 +115,11 @@ class ICEBERG_EXPORT Table {
/// \return a pointer to the new Transaction
virtual std::unique_ptr<Transaction> NewTransaction() const;
+ /// \brief Create a new expire snapshots operation for this table
+ ///
+ /// \return a shared pointer to the new ExpireSnapshots operation
+ virtual std::shared_ptr<ExpireSnapshots> NewExpireSnapshots();
Review Comment:
nit: return unique_ptr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
