zhjwpku commented on code in PR #370:
URL: https://github.com/apache/iceberg-cpp/pull/370#discussion_r2573019170


##########
src/iceberg/test/CMakeLists.txt:
##########
@@ -97,6 +97,8 @@ add_iceberg_test(expression_test
                  literal_test.cc
                  predicate_test.cc)
 
+add_iceberg_test(update_test SOURCES ../update/test/expire_snapshots_test.cc)

Review Comment:
   nit: I think this test file should be placed under src/iceberg/test/update/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to