akune commented on code in PR #14603:
URL: https://github.com/apache/iceberg/pull/14603#discussion_r2573177555
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -178,6 +182,47 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catalog", properties);
}
+ @Test
+ public void testInitializePostgres() {
+ testInitializeWithContainer(new PostgreSQLContainer());
+ }
+
+ @Test
+ public void testInitializeDb2() {
+ testInitializeWithContainer(new Db2Container());
+ }
+
+ @Test
+ public void testInitializeOracle() {
+ testInitializeWithContainer(new OracleContainer());
+ }
Review Comment:
I looked into the issue with the LIMIT in Oracle and provided a fix as well
as a test that runs with different database containers.
As far as I can tell this brings full Oracle support to JDBC catalog and
would close #10717.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
