ebyhr commented on code in PR #14603:
URL: https://github.com/apache/iceberg/pull/14603#discussion_r2548200183
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -178,6 +182,47 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catalog", properties);
}
+ @Test
+ public void testInitializePostgres() {
+ testInitializeWithContainer(new PostgreSQLContainer());
+ }
+
+ @Test
+ public void testInitializeDb2() {
+ testInitializeWithContainer(new Db2Container());
+ }
+
+ @Test
+ public void testInitializeOracle() {
+ testInitializeWithContainer(new OracleContainer());
+ }
Review Comment:
We should verify not only the initialization but also additional operations,
in my opinion. We still can’t use Oracle as the backend because of the LIMIT
issue, even after initialization, right? #10717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
