amogh-jahagirdar commented on code in PR #13400:
URL: https://github.com/apache/iceberg/pull/13400#discussion_r2553745099
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -594,7 +594,11 @@ default boolean shouldPlanTableScanAsync(TableScan
tableScan) {
}
protected PlanningBehavior planningBehavior() {
- return new PlanningBehavior() {};
+ return this.planningBehavior == null ? new PlanningBehavior() {} :
planningBehavior;
+ }
+
+ protected void setPlanningBehavior(PlanningBehavior behavior) {
+ this.planningBehavior = behavior;
Review Comment:
I still don't follow why this and the builder below is required? Are we not
able to override the planning behavior just once in a manner which will force
the client to exercise all the paths?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
