singhpk234 commented on code in PR #13400:
URL: https://github.com/apache/iceberg/pull/13400#discussion_r2539475089
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -247,6 +273,57 @@ public static <T> T roundTripSerialize(T payload, String
description) {
return null;
}
+ /** Configurable planning behavior for tests. Replaces magic table
name-based behavior routing. */
+ static class TestPlanningBehavior implements
RESTCatalogAdapter.PlanningBehavior {
+ private boolean asyncPlanning;
+ private int tasksPerPage;
+
+ static Builder builder() {
+ return new Builder();
+ }
+
+ @Override
+ public boolean shouldPlanTableScanAsync(TableScan tableScan) {
+ return asyncPlanning;
+ }
+
+ @Override
+ public int numberFileScanTasksPerPlanTask() {
+ return tasksPerPage;
+ }
+
+ static class Builder {
+ private TestPlanningBehavior behavior = new TestPlanningBehavior();
Review Comment:
I agree with you, with in the current iteration i just wanted to avoid
rewriting it based on one config (hence I was checking for setter for example i
need async / sync mode both), Let me think a bit more on how to factor in with
the feedback !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
