zhjwpku commented on code in PR #319: URL: https://github.com/apache/iceberg-cpp/pull/319#discussion_r2550071135
########## README.md: ########## @@ -31,6 +31,10 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). - CMake 3.25 or higher - C++23 compliant compiler +## Customizing Dependency URLs + +If you experience network issues when downloading dependencies, you can customize the download URLs using environment variables. See the available options documented in [`cmake_modules/IcebergThirdpartyToolchain.cmake`](cmake_modules/IcebergThirdpartyToolchain.cmake#L24-L40). Review Comment: IcebergThirdpartyToolchain.cmake can be changed, the link you put here is not stable. Why not directly put the quoted lines here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
