HuaHuaY commented on code in PR #319: URL: https://github.com/apache/iceberg-cpp/pull/319#discussion_r2527893592
########## README.md: ########## @@ -31,6 +31,8 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). - CMake 3.25 or higher - C++23 compliant compiler +> **Note**: For developers in China experiencing network issues when downloading dependencies, see [BUILD_CHINA.md](BUILD_CHINA.md) for mirror configuration. Review Comment: Agree with you. We have CMake options such as `ICEBERG_ARROW_URL` which allow users to customize urls. If other projects use specific urls for China, I would also support following this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
