rdblue commented on code in PR #14533: URL: https://github.com/apache/iceberg/pull/14533#discussion_r2539891816
########## core/src/main/java/org/apache/iceberg/InheritableTrackedMetadataFactory.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** Factory for creating {@link InheritableTrackedMetadata} instances. */ +class InheritableTrackedMetadataFactory { + + private InheritableTrackedMetadataFactory() {} + + /** + * Creates inheritable metadata from explicit values. + * + * @param snapshotId the snapshot ID + * @param sequenceNumber the sequence number + * @return inheritable metadata instance + */ + static InheritableTrackedMetadata create(long snapshotId, long sequenceNumber) { + return new BaseInheritableTrackedMetadata(snapshotId, sequenceNumber); + } + + /** + * Creates inheritable metadata from a tracked file representing a manifest (for reading leaf + * manifests). + * + * @param manifestEntry the DATA_MANIFEST or DELETE_MANIFEST tracked file from root + * @return inheritable metadata instance + */ + static InheritableTrackedMetadata fromTrackedFile(TrackedFile<?> manifestEntry) { Review Comment: Methods like this should accept a typed file, like `ManifestFile`, instead of converting. That way we can keep the conversion logic in a single place and the caller can either pass an existing `ManifestFile` or calls `trackedFile.asManifestFile()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
