rdblue commented on code in PR #14533: URL: https://github.com/apache/iceberg/pull/14533#discussion_r2539840457
########## api/src/main/java/org/apache/iceberg/TrackingInfo.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.types.Types; + +/** + * Tracking information for a tracked file entry in a V4 manifest. + * + * <p>This groups the status, snapshot, and sequence number information for the entry. This enables + * accessing the fields for the entry and provides an isolated structure that can be modified. + */ +public interface TrackingInfo { + /** Status of an entry in a tracked file */ + enum Status { + EXISTING(0), + ADDED(1), + DELETED(2); + + private final int id; + + Status(int id) { + this.id = id; + } + + public int id() { + return id; + } + } + + Types.NestedField STATUS = + Types.NestedField.required(0, "status", Types.IntegerType.get(), "Entry status"); + Types.NestedField SNAPSHOT_ID = + Types.NestedField.optional( + 1, + "snapshot_id", + Types.LongType.get(), + "Snapshot ID where the file was added, or deleted if status is 2. Inherited when null."); + Types.NestedField SEQUENCE_NUMBER = + Types.NestedField.optional( + 3, + "sequence_number", + Types.LongType.get(), + "Data sequence number of the file. Inherited when null and status is 1 (added). Must be equal to file_sequence_number if content_type is 3 or 4."); + Types.NestedField FILE_SEQUENCE_NUMBER = + Types.NestedField.optional( + 4, + "file_sequence_number", + Types.LongType.get(), + "File sequence number indicating when the file was added. Inherited when null and status is added. Must be equal to sequence_number if content_type is 3 or 4."); + Types.NestedField FIRST_ROW_ID = + Types.NestedField.optional( + 142, + "first_row_id", + Types.LongType.get(), + "The _row_id for the first row in the data file if content_type is 0. If content_type is 3, this is the starting _row_id to assign to rows added by ADDED data files."); + + /** + * Returns the status of the entry. + * + * <p>Status values: + * + * <ul> + * <li>0: EXISTING - file was already in the table + * <li>1: ADDED - file newly added + * <li>2: DELETED - file removed + * </ul> + */ + Status status(); + + /** + * Returns the snapshot ID where the file was added or deleted. + * + * <p>Inherited when null. + */ + Long snapshotId(); + + /** + * Returns the data sequence number of the file. + * + * <p>Inherited when null and status is 1 (added). Must be equal to file_sequence_number if + * content_type is 3 or 4. + */ + Long sequenceNumber(); Review Comment: Since this is a new interface, should we use `dataSequenceNumber` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
