flyrain commented on code in PR #14519:
URL: https://github.com/apache/iceberg/pull/14519#discussion_r2535646840
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1192,6 +1192,13 @@ paths:
- Catalog API
summary: Load vended credentials for a table from the catalog
operationId: loadCredentials
+ parameters:
+ - name: planId
+ in: query
+ required: false
+ schema:
+ type: string
+ description: The plan ID that has been used for server-side scan
planning
Review Comment:
I’m leaning toward having the server return a clear message when the planId
is invalid. I don’t think the fact that older servers ignore the parameter is a
big issue, they simply don’t support this behavior. The main goal is to make
the response from newer servers predictable when a planId is wrong. Is there a
use case that returning the generic credentials when plan id is invalid? We'd
probably avoid that if there is no use case. I think the spec doesn't say
anything at this moment, which means IRC impl. could do either way, return 404
or generic credentials. Is that what we intent to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
