nastra commented on code in PR #14519:
URL: https://github.com/apache/iceberg/pull/14519#discussion_r2533051873
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1192,6 +1192,13 @@ paths:
- Catalog API
summary: Load vended credentials for a table from the catalog
operationId: loadCredentials
+ parameters:
+ - name: planId
+ in: query
+ required: false
+ schema:
+ type: string
+ description: The plan ID that has been used for server-side scan
planning
Review Comment:
An older server won't know anything about this new query param, so it will
always ignore the planId. A newer server could do validation and throw when the
planId is invalid. The client doesn't necessarily know whether it talks to an
older or a newer server, meaning that the client would expect an error to be
thrown according to the spec, whereas the server would end up just ignoring the
planId. Additionally, a server could choose to return credentials that haven't
been scoped down to the planId in case the planId isn't valid anymore. Hence
why I'm a little hesitant to add this wording to the spec, unless we think that
server must always throw a 404 when the planId isn't valid anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
