rdblue commented on code in PR #14563:
URL: https://github.com/apache/iceberg/pull/14563#discussion_r2535162015


##########
open-api/rest-catalog-open-api.py:
##########
@@ -1493,6 +1493,9 @@ class CompletedPlanningResult(ScanTasks):
     """
 
     status: Literal['completed'] = Field(..., const=True)
+    storage_credentials: Optional[List[StorageCredential]] = Field(

Review Comment:
   Optional is the right choice. Services are not required to provide 
credentials at all and there are also strategies where planning is server-side 
and the client already has credentials from loading the table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to