singhpk234 commented on code in PR #14563:
URL: https://github.com/apache/iceberg/pull/14563#discussion_r2516638909
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3372,6 +3372,10 @@ components:
status:
$ref: '#/components/schemas/PlanStatus'
const: "completed"
+ storage-credentials:
Review Comment:
I wonder if we should have description here stating these creds are
subscoped to scan or something, thoughts ?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3372,6 +3372,10 @@ components:
status:
$ref: '#/components/schemas/PlanStatus'
const: "completed"
+ storage-credentials:
+ type: array
+ items:
+ $ref: '#/components/schemas/StorageCredential'
Review Comment:
shouldn't we be sending creds for AsyncPlanResult too ?
https://github.com/apache/iceberg/blob/0ce14b7ffd77337a4aee3de5cd19e697e731c19e/open-api/rest-catalog-open-api.yaml#L3399-L3409
cc @nastra as they also have a pr for making it part of
PlanTableScanResponse - https://github.com/apache/iceberg/pull/14518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
