huaxingao commented on code in PR #14196:
URL: https://github.com/apache/iceberg/pull/14196#discussion_r2528485718
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1781,13 +1880,19 @@ paths:
406:
$ref: '#/components/responses/UnsupportedOperationResponse'
409:
- description: Conflict - The target identifier to rename to already
exists as a table or view
+ description: |
+ Conflict - Multiple conflict scenarios possible:
+ - The target identifier to rename to already exists as a table or
view
+ - A request with the same Idempotency-Key is already in progress
content:
application/json:
schema:
$ref: '#/components/schemas/ErrorModel'
- example:
- $ref: '#/components/examples/ViewAlreadyExistsError'
+ examples:
+ NamespaceAlreadyExists:
+ $ref: '#/components/examples/ViewAlreadyExistsError'
+ IdempotencyInProgress:
Review Comment:
Good question. This 409 `IdempotencyInProgressError` is specifically for
cases where the first request with the same Idempotency-Key is still running.
Instead of blocking the duplicate until the original finishes (which could
take a long time or even hang if the first request stalls), the server can
immediately return 409 to tell the client that the operation is already in
progress.
Once the first request completes and finalizes, any later retries with the
same key will return that finalized result instead of this 409.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
