rdblue commented on code in PR #14196:
URL: https://github.com/apache/iceberg/pull/14196#discussion_r2528424220
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1781,13 +1880,19 @@ paths:
406:
$ref: '#/components/responses/UnsupportedOperationResponse'
409:
- description: Conflict - The target identifier to rename to already
exists as a table or view
+ description: |
+ Conflict - Multiple conflict scenarios possible:
+ - The target identifier to rename to already exists as a table or
view
+ - A request with the same Idempotency-Key is already in progress
content:
application/json:
schema:
$ref: '#/components/schemas/ErrorModel'
- example:
- $ref: '#/components/examples/ViewAlreadyExistsError'
+ examples:
+ NamespaceAlreadyExists:
+ $ref: '#/components/examples/ViewAlreadyExistsError'
+ IdempotencyInProgress:
Review Comment:
Mostly for my own understanding: Why is there an additional 409 error? If
another request has already failed then this would replay the other 409 result
(or a 200/204/etc result) so it wouldn't change. So when would we want to send
to the client that there is another request in flight, rather than waiting for
it to complete?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
