mbutrovich commented on code in PR #1856:
URL: https://github.com/apache/iceberg-rust/pull/1856#discussion_r2528100252
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -409,6 +418,8 @@ pub struct OutputFile {
path: String,
// Relative path of file to uri, starts at [`relative_path_pos`]
relative_path_pos: usize,
+ // Whether to use append mode for writes (required for some storage
backends like AZDLS)
+ append_file: bool,
Review Comment:
I'm generally not a fan of adding bools as args since it limits
extension/API changes in the future and sets a precedent for exponentially
complex input arguments that might not all be valid configs. Can we envision
any other things that we might want to encode in a `WriteMode` enum with one
value representing the current behavior and maybe an `Append` value. If the
answer is no then I'll accept the `bool`, otherwise we might consider an enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
