singhpk234 commented on code in PR #14581:
URL: https://github.com/apache/iceberg/pull/14581#discussion_r2524109360
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -48,6 +48,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
Review Comment:
thinking of a case like this, let's say engine wanna delete a record from a
file which just had one record in that case an engine might just optimize by
saying lets remove the whole file instead of producing a delete ? in this case
condition like below protects us :
```
if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
```
my understanding is we do support support removing data file in row delta
post this
- https://github.com/apache/iceberg/pull/12861
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -48,6 +48,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
Review Comment:
thinking of a case like this, let's say engine wanna delete a record from a
file which just had one record in that case an engine might just optimize by
saying lets remove the whole file instead of producing a delete ? in this case
condition like below protects us :
```
if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
```
my understanding is we do support support removing data file in row delta
post this
- https://github.com/apache/iceberg/pull/12861
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -48,6 +48,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
Review Comment:
thinking of a case like this, let's say engine wanna delete a record from a
file which just had one record in that case an engine might just optimize by
saying lets remove the whole file instead of producing a delete ? in this case
condition like below protects us :
```
if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
```
my understanding is we do support support removing data file in row delta
post this
- https://github.com/apache/iceberg/pull/12861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
