pvary commented on code in PR #14581:
URL: https://github.com/apache/iceberg/pull/14581#discussion_r2523878648
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -48,6 +48,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
Review Comment:
Based on the discussion
[here](https://github.com/apache/iceberg/pull/10123#discussion_r1561229088), I
think this should be enough:
```
if (addsDataFiles() && !addsDeleteFiles()) {
return DataOperations.APPEND;
}
```
> I think if (!addsDataFiles() && addsDeleteFiles()) is correct as the
RowDelta API only provides addRows(DataFile) and addDeletes(DeleteFile).
deletesDataFiles() would apply for the RewriteFiles API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
