amogh-jahagirdar commented on code in PR #14480:
URL: https://github.com/apache/iceberg/pull/14480#discussion_r2510294556
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -86,6 +99,9 @@
public class CatalogHandlers {
private static final Schema EMPTY_SCHEMA = new Schema();
private static final String INITIAL_PAGE_TOKEN = "";
+ private static final InMemoryPlanningState IN_MEMORY_PLANNING_STATE =
+ InMemoryPlanningState.getInstance();
Review Comment:
I think the challenge is the point brought up above with `planningBehavior`.
Currently, we want to override that in `CatalogTests` so we can
deterministically and at smaller scales get plan tasks/async planning to
validate the whole protocol. At the same time, `planningBehavior` should be
package private since it's not really something that should be exposed (which I
think it would have to be public if we wanted to plumb that through to
CatalogHandlers). I think these constraints make it so that some amount of
planning behavior gets into CatalogHandlers via the parameters on APIs , but
the actual planning state can be isolated separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
